Skip to content

fix(pm-dispatch): reject non-object JWT segments - #4241

Merged
dezren39 merged 1 commit into
mainfrom
queue/5422-2665-reject-non-object-jwt-header-payload
Nov 3, 2026
Merged

fix(pm-dispatch): reject non-object JWT segments#4241
dezren39 merged 1 commit into
mainfrom
queue/5422-2665-reject-non-object-jwt-header-payload

Conversation

@dezren39

@dezren39 dezren39 commented Nov 2, 2026 •
edited by blacksmith-sh Bot
Loading

Copy link
Copy Markdown
Member

Summary

  • Reject decoded JWT headers and payloads that are null, arrays, or scalar JSON values at the parse boundary.
  • Cover malformed segment shapes and assert they reach the existing AuthError path.

Fixes #2665

Validation

  • cd pm-stack/dispatch && bun test test/auth.test.ts — 17 passed.
  • cd pm-stack/dispatch && bun test — 101 passed across 9 files.
  • git diff --check — clean.
  • bun run typecheck is blocked by an existing error in unchanged test/queue.test.ts:17 (fetch mock missing Bun fetch preconnect).

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner November 2, 2026 06:53
@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 43 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 313536e0-426c-4a31-9029-2c8cf3b07a3c
Commits

Reviewing files that changed from the base of the PR and between 9456d01 and ba53f5a.

Files selected for processing: 2
  • pm-stack/dispatch/src/auth.ts
  • pm-stack/dispatch/test/auth.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T06:55:08.294865Z ba53f5a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dezren39 dezren39 added the user/review Needs a user-look: Muse reviews first and handles what it can label Nov 2, 2026
@dezren39

dezren39 commented Nov 2, 2026

Copy link
Copy Markdown
Member Author

🤖 Agent note · handed off

@dezren39 dezren39 mentioned this pull request Nov 2, 2026
Closed
4 tasks
@dezren39
dezren39 merged commit 115fe4f into main Nov 3, 2026
1 of 2 checks passed
@dezren39
dezren39 deleted the queue/5422-2665-reject-non-object-jwt-header-payload branch November 3, 2026 13:52
@dezren39 dezren39 mentioned this pull request Nov 4, 2026
Closed
@dezren39
dezren39 restored the queue/5422-2665-reject-non-object-jwt-header-payload branch November 8, 2026 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dezren39 dezren39

Labels

user/review Needs a user-look: Muse reviews first and handles what it can

Projects

None yet

Milestone

No milestone

1 participant

@dezren39